Skip to content

Fixed scope override inside metafunc.parametrize. Fixes #634 #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2016
Merged

Fixed scope override inside metafunc.parametrize. Fixes #634 #1766

merged 1 commit into from
Jul 25, 2016

Conversation

@Stranger6667
Copy link
Contributor

@Stranger6667 Stranger6667 commented Jul 25, 2016 •
edited
Loading

Hello, this is my initial approach to solve #634
I'm not very familiar with pytest codebase, so I'll appreciate any help here.
Thank you

P.S. Also #684 #661 #896 #531 are probably related to this issue

@coveralls
Copy link

coveralls commented Jul 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 92.296% when pulling af362b3 on Stranger6667:issue634-scopes into d37af20 on pytest-dev:master.

@coveralls
Copy link

coveralls commented Jul 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 92.296% when pulling e686f39 on Stranger6667:issue634-scopes into d37af20 on pytest-dev:master.

@RonnyPfannschmidt
Copy link
Member

@Stranger6667 good work, at first glance it indeed seems to solve quite many if not all of the related issues

@coveralls
Copy link

coveralls commented Jul 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 92.301% when pulling d72afe7 on Stranger6667:issue634-scopes into a2b04d0 on pytest-dev:master.

@nicoddemus nicoddemus merged commit d72afe7 into pytest-dev:master Jul 25, 2016
@nicoddemus
Copy link
Member

Thanks!

@nicoddemus nicoddemus mentioned this pull request Jul 25, 2016
Closed
@Stranger6667 Stranger6667 deleted the issue634-scopes branch July 26, 2016 03:24
This was referenced Jul 26, 2016
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Stranger6667 @coveralls @RonnyPfannschmidt @nicoddemus